The Mood bar

communismbelike · February 4, 2024, 10:44pm

So, I have noticed that once you hit insanity, for mood, you have a certain amount of time before the moodlet text bugs out and you become perma stuck in insanity, giving you a massive movement debuff, is this intentional? or is it a bug?

joelogbybolb · February 5, 2024, 1:13am

Insanity is permanent, I think. Don’t take hypersensitive if you don’t wanna babysit your mood

TheMaggotGuy · February 5, 2024, 1:14am

It’s a bug; it shouldn’t be blank, and unstable supposedly changes so that “you are unable to recover your sanity if you lose it”.

therefore normally you should be able to recover your sanity if you lose it.

yedrtufygkuhil

joelogbybolb · February 5, 2024, 1:36am

insanity is a permanent loss of mood, that’s the point

TheMaggotGuy · February 5, 2024, 1:42am

Then why have the unstable perk? What is it supposed to do, if not that?

auce · February 5, 2024, 6:12am

Unstable seems like 2 free trait points if everyone already can’t recover their sanity.

RDS88 · February 5, 2024, 11:06am

If it’s meant to be a permanent loss of mood, why is the interface so fucky. You’d at least think they’d have a line of text for it.

RDS88 · February 5, 2024, 11:31am

Okay, I think I found the issue

Sanity Code

///Called on SSmood process
/datum/component/mood/process(delta_time)
	var/mob/living/owner = parent
	switch(sanity)
		if(SANITY_GREAT-1 to INFINITY)
			setSanity(sanity+sanity_modifier*delta_time*mood-0.4)
		if(SANITY_NEUTRAL-1 to SANITY_GREAT-1)
			setSanity(sanity+sanity_modifier*delta_time*mood-0.2)
		if(SANITY_DISTURBED-1 to SANITY_NEUTRAL-1)
			setSanity(sanity+sanity_modifier*delta_time*mood)
		if(SANITY_UNSTABLE-1 to SANITY_DISTURBED-1)
			setSanity(sanity+sanity_modifier*delta_time*mood+0.3)
		if(SANITY_CRAZY-1 to SANITY_UNSTABLE-1)
			setSanity(sanity+sanity_modifier*delta_time*mood+0.6)
		if(SANITY_INSANE-1 to SANITY_CRAZY)
			setSanity(sanity+sanity_modifier*delta_time*mood+0.9)
	HandleNutrition(owner)

In this code, the sanity values all have -1 attached to them for this formula specifically. If you bottom out your mood, this formula can spit out a negative value for your new sanity, which works within itself but doesn’t work for any of the other formulas. For instance

Code that controls how the UI prints

/datum/component/mood/proc/print_mood(mob/user)
	var/msg = "<span class='info'><EM>Your current mood</EM>\n"
	msg += "<span class='notice'>My mental status: </span>" //Long term
	switch(sanity)
		if(SANITY_GREAT to INFINITY)
			msg += "<span class='nicegreen'>My mind feels like a temple!<span>\n"
		if(SANITY_NEUTRAL to SANITY_GREAT)
			msg += "<span class='nicegreen'>I have been feeling great lately!<span>\n"
		if(SANITY_DISTURBED to SANITY_NEUTRAL)
			msg += "<span class='nicegreen'>I have felt quite decent lately.<span>\n"
		if(SANITY_UNSTABLE to SANITY_DISTURBED)
			msg += "<span class='warning'>I'm feeling a little bit unhinged...</span>\n"
		if(SANITY_CRAZY to SANITY_UNSTABLE)
			msg += "<span class='boldwarning'>I'm freaking out!!!</span>\n"
		if(SANITY_INSANE to SANITY_CRAZY)
			msg += "<span class='boldwarning'>AHAHAHAHAHAHAHAHAHAH!!!</span>\n"

This doesn’t account for negative sanity, which would result in the lack of printed text that we see when the bug occurs.

Assuming all of these moodlets in Maggot’s screenshot add up to about +20 or so, the formula for calculating his sanity every mood tick would look something like this.

sanity+sanity_modifier*delta_time*mood+0.9
(-3+0.05*20+0.9),

which would result in a sanity value of -59, give or take.
I think I know the exact PR that broke it too.

github.com/BeeStation/BeeStation-Hornet

Sanity gradually moves towards a neutral state

BeeStation:master ← WrillWasTaken:sanity-bias

opened 08:41PM - 23 Mar 23 UTC

WrillWasTaken

+14 -19

## About The Pull Request Makes sanity gradually move towards a neutral state, …with speed varying depending on how low/high your sanity is. I tweaked the speed so that it prevents you from losing more sanity without having a worse mood. Same applies for happiness, you won't love life because you took a shower anymore, but it's easier to be happy than it is to go insane. To be more specific, you need _at least_ a mood of -18 to reach 0 sanity, and _at least_ a mood of 8 to reach maximum. ## Why It's Good For The Game Bottoming out on sanity over very tiny moodlets is silly and honestly immersion breaking imo. It's ridiculous that taking a shower makes your mind a temple, or mild inconveniences make you go insane.  ## Testing Photographs and Procedure <details> <summary>Screenshots&Videos</summary> Not really sure how to show it works, since the only testing videos I made are too big for github. I did test it though. ![image](https://user-images.githubusercontent.com/86113712/227349940-bdc3c57a-9878-4fe6-a58a-0621aa91b707.png) </details> ## Changelog :cl: tweak: Sanity constantly moves towards a neutral state. tweak: Sanity change speed from mood is no longer capped. Extremely low moods will make you go insane extremely fast, and vice versa. /:cl:

This pull request refactored mood to be multiplied into your sanity change formula, and since you can get negative mood and low sanity, this means you can get negative numbers now, where you couldn’tve before.

OKAY ERRATA I’M STUPID
I think the bug ACTUALLY arises when you get a sanity value of below -1. Then it fails all the checks in the sanity adjustment formula, and can never change again, getting frozen at a negative value. The fix is actually really simple, I think.

RDS88 · February 5, 2024, 1:04pm

https://github.com/BeeStation/BeeStation-Hornet/pull/10574
fixed it maybe???

github.com/BeeStation/BeeStation-Hornet

Fixes sanity getting stuck at insane and breaking the UI

BeeStation:master ← RDS88-beeman:insanity-fix-by-an-insane-person

opened 05:26PM - 05 Feb 24 UTC

RDS88-beeman

+2 -0

## About The Pull Request Adds a clamp to the sanity value for players, making …it so they can't go below 0. Zero is still very much insane, but prevents the sanity value from falling outside of the bounds the game looks for, which causes it to get stuck at that point. While you could also just expand the range of values the game looks for, that could cause unintended behavior when multiplying two large negative numbers. I think this is best. ## Why It's Good For The Game Fixes a slightly UI breaking and very annoying bug. ## Testing Photographs and Procedure <details> <summary>Screenshots&Videos</summary> Still don't know how to screenshot this. People aren't going insane immediately, so win? </details> ## Changelog :cl: fix: Made it so that you can't become so insane that the entire sanity system breaks. /:cl:

okay this link works

system · February 12, 2024, 1:04pm

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.