Hi. I just wanted to point out a small bug that really annoys me. Hyphens are broken now and mess up the IC text or something won’t even let you send the message. This has happened recently so I just want to make it know.
Example of bug 1:
Example of bug 2
This message doesn’t even send. So you can no longer RP having your conservation interrupted.
4 Likes
BIDP
January 24, 2023, 3:19pm
2
I also made a report about this on git!
BeeStation:master
← Bobbanz1:SomethingAboutCheese
opened 12:50PM - 23 Jan 23 UTC
## About The Pull Request
Fixes a few issues that were created by
* https://gi… thub.com/BeeStation/BeeStation-Hornet/pull/8136
Also changes the custom say trigger character from `-` to `/`
Also removes the stack_trace as that would potentially become rapidly annoying for anyone trying to find runtime errors as it would apparently trigger every single time someone sent a custom say emote without any message afterwards, so for example:
"screams/" would produce a stack_trace.
Instead the message is now returned as an empty string.
## Why It's Good For The Game
Bug fixes.
Allows for people to cut off sentences without turning it into a custom say emote
<!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding.
-->
## Testing Photographs and Procedure
<details>
<summary>Screenshots&Videos</summary>
https://user-images.githubusercontent.com/59128051/214043773-5c29efb1-e912-4902-b726-71952d21a500.mp4
https://user-images.githubusercontent.com/59128051/214043784-8bfd2d3f-6b72-4186-a295-efda17d800bb.mp4
</details>
## Changelog
:cl:
fix: Fixed an issue that was being caused by custom say that was clashing with roleplaying by changing the trigger letter to /
/:cl:
4 Likes
Oh, I thought this was a feature haha, mixed emotes and speech are cool!
Though I wish it was on a character not used in actual speech.
Can it be removed from making it ‘me’ or ‘emote’ post, or completely deleting the talk you were suppose to be talking?
So many peoples are using these dash marks for marking out something, or quickly cut talkings like “So, for example-” (Then something happens around here)
But with this… Hidden update or something, it now messes up the conversation as well for good, or make a poor attempted announcement on the radio.
BIDP
January 26, 2023, 3:39pm
5
its not a hidden update. The RP that made this change is still being actively worked on. you can see the comments on it below on this link:
BeeStation:master
← Bobbanz1:SomethingAboutCheese
opened 12:50PM - 23 Jan 23 UTC
## About The Pull Request
Fixes a few issues that were created by
* https://gi… thub.com/BeeStation/BeeStation-Hornet/pull/8136
Also changes the custom say trigger character from `-` to `/`
Also removes the stack_trace as that would potentially become rapidly annoying for anyone trying to find runtime errors as it would apparently trigger every single time someone sent a custom say emote without any message afterwards, so for example:
"screams/" would produce a stack_trace.
Instead the message is now returned as an empty string.
## Why It's Good For The Game
Bug fixes.
Allows for people to cut off sentences without turning it into a custom say emote
<!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding.
-->
## Testing Photographs and Procedure
<details>
<summary>Screenshots&Videos</summary>
https://user-images.githubusercontent.com/59128051/214043773-5c29efb1-e912-4902-b726-71952d21a500.mp4
https://user-images.githubusercontent.com/59128051/214043784-8bfd2d3f-6b72-4186-a295-efda17d800bb.mp4
</details>
## Changelog
:cl:
fix: Fixed an issue that was being caused by custom say that was clashing with roleplaying by changing the trigger letter to /
/:cl:
1 Like
I can’t really understand why people say that we (or any other project) roll out hidden changes/updates when everything we do is fully transparent on GitHub. I can understand not being able to fully read the code, but, that’s part of why we have readable PRs bodies.
Literally in the changelog
system
Closed
March 27, 2023, 5:18pm
8
This topic was automatically closed 60 days after the last reply. New replies are no longer allowed.